Skip to content

Make firstRange and lastRange mirror macOS Foundation more #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

Frizlab
Copy link
Contributor

@Frizlab Frizlab commented Mar 28, 2021

When the searched Data is empty, on macOS nil is returned, on Linux an empty Range is returned.
This PR fixes the discrepancy.

@spevans
Copy link
Contributor

spevans commented Mar 28, 2021

This looks fine but could you also add a test case please.

@Frizlab
Copy link
Contributor Author

Frizlab commented Mar 29, 2021

@spevans Done!

@spevans
Copy link
Contributor

spevans commented Mar 29, 2021

@swift-ci test

@Frizlab
Copy link
Contributor Author

Frizlab commented Mar 30, 2021

Reading the output of the test bot, I don’t think the failure comes from my patch. Is there something I should do?

@spevans
Copy link
Contributor

spevans commented Mar 30, 2021

@Frizlab There are some other issues with the CI at the moment that are being fixed in #2994
Once that is merged I will retest your PRs

@spevans
Copy link
Contributor

spevans commented Apr 1, 2021

@swift-ci test linux

@CodaFi
Copy link
Contributor

CodaFi commented Jun 9, 2021

@swift-ci test

@CodaFi
Copy link
Contributor

CodaFi commented Jun 9, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants